Re: [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf

[Shivaprasad G Bhat]

On 6/25/22 05:12, Santosh Sivaraj wrote:
> I don't have setup to test this now. Adding Shiva and Vaibhav who could 
> probably help. Thanks, Santosh On Sat, 25 Jun, 2022, 1:03 am Dan 
> Williams, <dan.j.williams@xxxxxxxxx> wrote: [ add Santosh ] Kent 
> Overstreet wrote: ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍
> ZjQcmQRYFpfptBannerStart
> This Message Is From an External Sender
> This message came from outside your organization.
> ZjQcmQRYFpfptBannerEnd
> I don't have setup to test this now. Adding Shiva and Vaibhav who could 
> probably help.
>
> Thanks,
> Santosh
>
> On Sat, 25 Jun, 2022, 1:03 am Dan Williams, <dan.j.williams@xxxxxxxxx 
> <mailto:dan.j.williams@xxxxxxxxx>> wrote:
>
>     [ add Santosh ]
>
>     Kent Overstreet wrote:
>      > This converts from seq_buf to printbuf. Here we're using printbuf
>     with
>      > an external buffer, meaning it's a direct conversion.
>      >
>      > Signed-off-by: Kent Overstreet <kent.overstreet@xxxxxxxxx
>     <mailto:kent.overstreet@xxxxxxxxx>>
>      > Cc: Dan Williams <dan.j.williams@xxxxxxxxx
>     <mailto:dan.j.williams@xxxxxxxxx>>
>      > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx
>     <mailto:dave.hansen@xxxxxxxxxxxxxxx>>
>      > Cc: nvdimm@xxxxxxxxxxxxxxx <mailto:nvdimm@xxxxxxxxxxxxxxx>
>
>     Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx
>     <mailto:dan.j.williams@xxxxxxxxx>>

The ndtest build requires [1] as the build is currently broken from 
nd_namespace_blk/blk_region infrastructure removal.

Dan, Could you review [1] and see if it can be included as well ?

With [1], the this patch is tested, and works fine.

Tested-By: Shivaprasad G Bhat <sbhat@xxxxxxxxxxxxx>

References:
[1] 
https://patchwork.kernel.org/project/linux-nvdimm/patch/165025395730.2821159.14794984437851867426.stgit@xxxxxxxxxxxxxxxxxxxxxxxxx/


>     This probably also wants a Tested-by from Santosh, but it looks ok
>     to me.