On Tue, Jul 5, 2022 at 5:02 PM John Garry<john.garry@xxxxxxxxxx> wrote:
On 05/07/2022 12:43, Andy Shevchenko wrote:"The OF is not guarded, neither ACPI needs it."
The OF is not guarded, neither ACPI needs.This doesn't read well.
Better? Otherwise please propose how it can be amended here.
Strictly speaking, yes we need mod_devicetable.h. But of.h and acpi.hThe IDs do not dependDo you need to explicitly include mod_devicetable.h, which has the
to the configuration. Hence drop ACPI_PTR() from the code and
move ID table closer to its user.
definition of acpi_device_id?
I saw a similar change for another driver and it was claimed that
including mod_devicetable.h was required.
include it.
What you have seen is probably dropping of.h and/or acpi.h completely
from the user.
In such cases the mod_devicetable.h is compulsory.