答复: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops

[shaozhengchao]

-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@xxxxxxxxxx] 
发送时间: 2022年7月6日 9:43
收件人: shaozhengchao <shaozhengchao@xxxxxxxxxx>
抄送: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; jhs@xxxxxxxxxxxx; xiyou.wangcong@xxxxxxxxx; jiri@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx; weiyongjun (A) <weiyongjun1@xxxxxxxxxx>; yuehaibing <yuehaibing@xxxxxxxxxx>
主题: Re: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops

On Mon, 4 Jul 2022 20:43:22 +0800 Zhengchao Shao wrote:
> Return value of unregister_tcf_proto_ops is useless, remove it.

s/useless/unused/ ?

Should we add a WARN if the ops getting removed can't be found or there are callers which depend on handling unregistered ops without a warning?

Hi Jakub Kicinski:
	Thank you for your apply. This patch does just remove the return value and change the function type from int to void. It doesn't remove the function.

Zhengchao Shao