Re: [PATCH] eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write()

From: Dan Carpenter
Date: Wed Jul 06 2022 - 06:41:00 EST


On Wed, Jul 06, 2022 at 09:58:51AM +0300, Dan Carpenter wrote:
> The simple_write_to_buffer() here is used to copy a string from the
> user. However the function call will succeed if it manages to read
> just one byte anywhere within the buffer while we need the whole string
> to be initialized to avoid using uninitialized data.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---

NAK. The strndup_user() function is too strict. I will resend this
using memdup_user() instead.

regards,
dan carpenter