Re: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

[Nicolin Chen]

On Thu, Jul 07, 2022 at 08:46:12AM +0000, Tian, Kevin wrote:
> External email: Use caution opening links or attachments
> 
> 
> > From: Nicolin Chen
> > Sent: Wednesday, July 6, 2022 2:28 PM
> >  /*
> > - * Pin a set of guest PFNs and return their associated host PFNs for local
> > + * Pin contiguous guest pages and return their associated host pages for
> > local
> 
> can we replace 'guest' with 'user'?
> 
> >   * domain only.
> >   * @device [in]  : device
> > - * @user_pfn [in]: array of user/guest PFNs to be pinned.
> > - * @npage [in]   : count of elements in user_pfn array.  This count should
> > not
> > + * @iova [in]    : starting IOVA of user/guest pages to be pinned.
> 
> remove 'guest'.
> 
> > + * @npage [in]   : count of pages to be pinned.  This count should not
> >   *              be greater VFIO_PIN_PAGES_MAX_ENTRIES.
> 
> greater 'than' ...

Will update them in v3. Thanks