Re: [PATCH 05/13] tracing/iwlwifi: Use the new __vstring() helper

From: Kalle Valo
Date: Fri Jul 08 2022 - 01:03:25 EST


Steven Rostedt <rostedt@xxxxxxxxxxx> writes:

> From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
>
> Instead of open coding a __dynamic_array() with a fixed length (which
> defeats the purpose of the dynamic array in the first place). Use the new
> __vstring() helper that will use a va_list and only write enough of the
> string into the ring buffer that is needed.
>
> Cc: Gregory Greenman <gregory.greenman@xxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> ---
> .../net/wireless/intel/iwlwifi/iwl-devtrace-msg.h | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)

Feel free to take this via your tree:

Acked-by: Kalle Valo <kvalo@xxxxxxxxxx>

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches