Re: [PATCH] ASoC: mediatek: mt8186: Remove condition with no effect

From: Matthias Brugger
Date: Fri Jul 08 2022 - 04:11:49 EST

On 08/07/2022 10:01, AngeloGioacchino Del Regno wrote:
Il 08/07/22 04:46, Zhongjun Tan ha scritto:
From: Zhongjun Tan <tanzhongjun@xxxxxxxxxxx>

Remove condition with no effect

Signed-off-by: Zhongjun Tan <tanzhongjun@xxxxxxxxxxx>
  sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
index db71b032770d..6be6d4f3b585 100644
--- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
+++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
@@ -295,8 +295,6 @@ static int mtk_adda_pad_top_event(struct snd_soc_dapm_widget *w,
      case SND_SOC_DAPM_PRE_PMU:
          if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2_CLK_P2)
              regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x39);
-        else if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2)
-            regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31);

I think that this needs some clarification from MediaTek: was 0x31 a typo here?

Looks like the write is covered by the else case already, so we don't need the else if here. In any case commit message could be improved.



              regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31);