[stable:linux-5.10.y 644/6933] drivers/scsi/BusLogic.c:2006:47: error: 'DMA_MODE_CASCADE' undeclared; did you mean 'DMA_MODE_READ'?
From: kernel test robot
Date: Fri Jul 08 2022 - 07:10:53 EST
Hi Arnd,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y
head: 7208d1236f72085a3290c41463ee3ee246d8afa5
commit: 87ae522e467e17a13b796e2cb595f9c3943e4d5e [644/6933] m68knommu: only set CONFIG_ISA_DMA_API for ColdFire sub-arch
config: m68k-randconfig-r003-20220703 (https://download.01.org/0day-ci/archive/20220708/202207081920.7UbEitt3-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=87ae522e467e17a13b796e2cb595f9c3943e4d5e
git remote add stable https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
git fetch --no-tags stable linux-5.10.y
git checkout 87ae522e467e17a13b796e2cb595f9c3943e4d5e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from drivers/scsi/BusLogic.c:25:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:169:50: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:9: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:17: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from drivers/scsi/BusLogic.c:51:
drivers/scsi/FlashPoint.c: In function 'FlashPoint_AbortCCB':
drivers/scsi/FlashPoint.c:1618:23: warning: variable 'TID' set but not used [-Wunused-but-set-variable]
1618 | unsigned char TID;
| ^~~
drivers/scsi/BusLogic.c: In function 'blogic_rdconfig':
drivers/scsi/BusLogic.c:1735:46: warning: ordered comparison of pointer with null pointer [-Wextra]
1735 | (void *) high_memory > (void *) MAX_DMA_ADDRESS)
| ^
drivers/scsi/BusLogic.c:1748:46: warning: ordered comparison of pointer with null pointer [-Wextra]
1748 | (void *) high_memory > (void *) MAX_DMA_ADDRESS)
| ^
drivers/scsi/BusLogic.c: In function 'blogic_getres':
>> drivers/scsi/BusLogic.c:2006:47: error: 'DMA_MODE_CASCADE' undeclared (first use in this function); did you mean 'DMA_MODE_READ'?
2006 | set_dma_mode(adapter->dma_ch, DMA_MODE_CASCADE);
| ^~~~~~~~~~~~~~~~
| DMA_MODE_READ
drivers/scsi/BusLogic.c:2006:47: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/BusLogic.c: In function 'blogic_msg':
drivers/scsi/BusLogic.c:3591:9: warning: function 'blogic_msg' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
3591 | len = vsprintf(buf, fmt, args);
| ^~~
vim +2006 drivers/scsi/BusLogic.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1980
839cb99e8f7483 Khalid Aziz 2013-05-16 1981 static bool __init blogic_getres(struct blogic_adapter *adapter)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1982 {
839cb99e8f7483 Khalid Aziz 2013-05-16 1983 if (adapter->irq_ch == 0) {
839cb99e8f7483 Khalid Aziz 2013-05-16 1984 blogic_err("NO LEGAL INTERRUPT CHANNEL ASSIGNED - DETACHING\n",
839cb99e8f7483 Khalid Aziz 2013-05-16 1985 adapter);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1986 return false;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1987 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1988 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 1989 Acquire shared access to the IRQ Channel.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1990 */
839cb99e8f7483 Khalid Aziz 2013-05-16 1991 if (request_irq(adapter->irq_ch, blogic_inthandler, IRQF_SHARED,
839cb99e8f7483 Khalid Aziz 2013-05-16 1992 adapter->full_model, adapter) < 0) {
839cb99e8f7483 Khalid Aziz 2013-05-16 1993 blogic_err("UNABLE TO ACQUIRE IRQ CHANNEL %d - DETACHING\n",
839cb99e8f7483 Khalid Aziz 2013-05-16 1994 adapter, adapter->irq_ch);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1995 return false;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1996 }
839cb99e8f7483 Khalid Aziz 2013-05-16 1997 adapter->irq_acquired = true;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1998 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 1999 Acquire exclusive access to the DMA Channel.
^1da177e4c3f41 Linus Torvalds 2005-04-16 2000 */
839cb99e8f7483 Khalid Aziz 2013-05-16 2001 if (adapter->dma_ch > 0) {
839cb99e8f7483 Khalid Aziz 2013-05-16 2002 if (request_dma(adapter->dma_ch, adapter->full_model) < 0) {
839cb99e8f7483 Khalid Aziz 2013-05-16 2003 blogic_err("UNABLE TO ACQUIRE DMA CHANNEL %d - DETACHING\n", adapter, adapter->dma_ch);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2004 return false;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2005 }
839cb99e8f7483 Khalid Aziz 2013-05-16 @2006 set_dma_mode(adapter->dma_ch, DMA_MODE_CASCADE);
839cb99e8f7483 Khalid Aziz 2013-05-16 2007 enable_dma(adapter->dma_ch);
839cb99e8f7483 Khalid Aziz 2013-05-16 2008 adapter->dma_chan_acquired = true;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2009 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2010 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 2011 Indicate the System Resource Acquisition completed successfully,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2012 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 2013 return true;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2014 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2015
:::::: The code at line 2006 was first introduced by commit
:::::: 839cb99e8f748391059d10388c8aea48a88c142c [SCSI] BusLogic: Fix style issues
:::::: TO: Khalid Aziz <khalid.aziz@xxxxxxxxxx>
:::::: CC: James Bottomley <JBottomley@xxxxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://01.org/lkp