Re: [PATCH] x86/mm/tlb: ignore f->new_tlb_gen when zero

From: Dave Hansen
Date: Fri Jul 08 2022 - 13:06:19 EST


On 7/8/22 09:54, Nadav Amit wrote:
> Since the bug was not during MADV_DONTNEED there is no reason for the
> results to be any different.
>
> Famous last words?

Considering that your patch broke the kernel a way that surprised us
all, I think caution is warranted. Re-running a microbenchmark that
takes five minutes and stresses things a bit is the least you can do, I
think.