Re: [PATCH 1/2] staging: vt6655: Use loop in vt6655_mac_write_bssid_addr
From: Joe Perches
Date: Sat Jul 09 2022 - 00:21:34 EST
On Fri, 2022-07-08 at 14:29 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 06, 2022 at 09:19:01PM +0200, Philipp Hortmann wrote:
> > Use loop in vt6655_mac_write_bssid_addr to avoid multiple
> > similar statements.
> > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> > @@ -192,12 +192,8 @@ device_set_options(struct vnt_private *priv)
> > static void vt6655_mac_write_bssid_addr(void __iomem *iobase, const u8 *mac_addr)
> > + for (int i = 0; i < 6; i++)
> Taking advantage of the new compiler level I see, nice :)
Not sure this is altogether a great idea as it may
make backporting a bit difficult, but it's already
in the kernel in a few places.