Re: [PATCH 0/6] drm/ingenic: JZ4760(B) support and random changes

From: Paul Cercueil
Date: Sat Jul 09 2022 - 06:43:45 EST


Hi Sam,

Le sam., juil. 9 2022 at 10:31:45 +0200, Sam Ravnborg <sam@xxxxxxxxxxxx> a écrit :
Hi Paul,

On Fri, Jul 08, 2022 at 09:54:00PM +0100, Paul Cercueil wrote:
Hi,

A small set of changes to the ingenic-drm driver.

The most notable thing is that ingenic-ipu is now its own platform
driver.
It would be nice to know what is achieved by this change, I could
see the code being a tad simpler, but the cost was more EXPORTs.

Well… we now have two separate drivers instead of one driver that deals with two different devices. I thought the benefit here was obvious.

With the added explanation, which you can add when applying, all patches are:
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

I'll apply the other ones and keep this patch for a V2. You made me realize that I could use namespaced exports instead of global ones.

Thanks,
-Paul