Re: [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support
From: Hans de Goede
Date: Sat Jul 09 2022 - 10:50:17 EST
<accidentally hit send to soon, trying again>
On 7/9/22 13:44, Andy Shevchenko wrote:
> You have sent two patches with the same version, your submission
> confuses everybody, which one are we supposed to consider?
Also the From of this email: PaddyKP_Yao <ispaddy@xxxxxxxxx> and
Signed-off-by: PaddyKP_Yao <PaddyKP_Yao@xxxxxxxx>
do not match. If you want the Author field of the commit to
bet set to match the Signed-off-by, but have trouble submitting
patches from your Asus email I can fix this up for you when
applying. Please let me know if you want me to do this;
or fix this issue for your next patch.
> On Fri, Jul 8, 2022 at 11:08 AM PaddyKP_Yao <ispaddy@xxxxxxxxx> wrote:
>> In some new ASUS devices, hotkey Fn+F13 is used for mic mute. If mic-mute
>> LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
>> mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
>> it. The binding of mic-mute LED controls will be swithched with LED
> Not reviewing code because of the above.
> Hint: `git format-patch -vX ...`, where X is a version number will
> help. And when cooking a new version don't forget to add a changelog
> between versions.