Re: [PATCH tip v8] x86/setup: Use rng seeds from setup_data

From: Borislav Petkov
Date: Sat Jul 09 2022 - 17:57:29 EST


On Sat, Jul 09, 2022 at 02:45:24PM -0700, H. Peter Anvin wrote:
> On 7/9/22 02:49, Borislav Petkov wrote:
> > On Fri, Jul 08, 2022 at 06:51:16PM -0700, H. Peter Anvin wrote:
> > > #define SETUP_ENUM_MAX SETUP_RNG_SEED
> > > #define SETUP_INDIRECT (1<<31)
> > > #define SETUP_TYPE_MAX (SETUP_ENUM_MAX | SETUP_INDIRECT)
> >
> > Wait, if we get to add a new number, SETUP_ENUM_MAX and thus
> > SETUP_TYPE_MAX will change. And they're uapi too...
>
> Talking API here rather than ABI, i.e. the semantics of those symbols.

Sure but do we worry about some userspace including those headers and
relying on the SETUP_ENUM_MAX number?

Or is userspace required to be recompiled against newer uapi headers?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette