Re: [PATCH v2] staging: qlge: Fix indentation issue under long for loop

[binyi]

On Sun, Jul 10, 2022 at 08:28:57AM -0700, Joe Perches wrote:
> On Sun, 2022-07-10 at 01:36 -0700, Binyi Han wrote:
> > Fix indentation issue to adhere to Linux kernel coding style,
> > Issue found by checkpatch. And change the long for loop into 3 lines.
> > 
> > Signed-off-by: Binyi Han <dantengknight@xxxxxxxxx>
> > ---
> > v2:
> > 	- Change the long for loop into 3 lines.
> > 
> >  drivers/staging/qlge/qlge_main.c | 18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> > index 1a378330d775..6e771d0e412b 100644
> > --- a/drivers/staging/qlge/qlge_main.c
> > +++ b/drivers/staging/qlge/qlge_main.c
> > @@ -3007,10 +3007,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> >  		tmp = (u64)rx_ring->lbq.base_dma;
> >  		base_indirect_ptr = rx_ring->lbq.base_indirect;
> >  
> > -		for (page_entries = 0; page_entries <
> > -			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> > -				base_indirect_ptr[page_entries] =
> > -					cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> > +		for (page_entries = 0;
> > +			page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> > +			page_entries++)
> > +			base_indirect_ptr[page_entries] =
> > +				cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> 
> Better to align page_entries to the open parenthesis.
> 
> And another optimization would be to simply add DB_PAGE_SIZE to tmp
> in the loop and avoid the multiply.
> 
> 		for (page_entries = 0;
> 		     page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> 		     page_entries++) {
> 			base_indirect_ptr[page_entries] = cpu_to_le64(tmp);
> 			tmp += DB_PAGE_SIZE;
> 		}
> 
> > @@ -3022,10 +3023,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> >  		tmp = (u64)rx_ring->sbq.base_dma;
> >  		base_indirect_ptr = rx_ring->sbq.base_indirect;
> >  
> > -		for (page_entries = 0; page_entries <
> > -			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> > -				base_indirect_ptr[page_entries] =
> > -					cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> > +		for (page_entries = 0;
> > +			page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> > +			page_entries++)
> > +			base_indirect_ptr[page_entries] =
> > +				cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> 
> here too
> 

Ah I see, that makes sense. Thanks for reviewing!