Re: [PATCH v2 01/11] mfd: intel_soc_pmic_bxtwc: Don't shadow error codes in show()/store()

From: Lee Jones
Date: Mon Jul 11 2022 - 04:15:57 EST


On Wed, 29 Jun 2022, Andy Shevchenko wrote:

> kstrtox() along with regmap API can return different error codes based on
> circumstances.
>
> Don't shadow them when returning to the caller.
>
> While at it, remove rather confusing message from addr_store().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> v2: dropped a confusing message as well (Lee)
> drivers/mfd/intel_soc_pmic_bxtwc.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog