Re: [PATCH 0/5] drm/modes: Command line mode selection fixes and improvements

[Thomas Zimmermann]

Hi

Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven:
> 	Hi all,
>
> This patch series contains fixes and improvements for specifying video
> modes on the kernel command line.
>
> This has been tested on ARAnyM using a work-in-progress Atari DRM driver
> (more info and related patches can be found in [1]).
>
> Thanks for your comments!

Patches 1 to 3 look reasonable to me. For those:

Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Please see my questions on patch 4.

Best regards
Thomas

> [1] "[PATCH v3 00/10] drm: Add support for low-color frame buffer formats"
>      https://lore.kernel.org/r/cover.1657294931.git.geert@xxxxxxxxxxxxxx
>
> Geert Uytterhoeven (5):
>    drm/modes: parse_cmdline: Handle empty mode name part
>    drm/modes: Extract drm_mode_parse_cmdline_named_mode()
>    drm/modes: parse_cmdline: Make mode->*specified handling more uniform
>    drm/modes: Add support for driver-specific named modes
>    drm/modes: parse_cmdline: Add support for named modes containing
>      dashes
>
>   drivers/gpu/drm/drm_modes.c | 57 ++++++++++++++++++++++++++-----------
>   include/drm/drm_connector.h | 10 +++++++
>   2 files changed, 50 insertions(+), 17 deletions(-)

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature