Re: [PATCH v1 2/3] dt-binding: power: power-domain: add power-supply-needs-irq
From: Krzysztof Kozlowski
Date: Mon Jul 11 2022 - 07:17:03 EST
On 11/07/2022 11:45, Martin Kepplinger wrote:
> Add the power-supply-needs-irq board description property for power domains.
Where is a board description here? I think you just meant
> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
> .../devicetree/bindings/power/power-domain.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml
> index 889091b9814f..e82c2f7ccb97 100644
> --- a/Documentation/devicetree/bindings/power/power-domain.yaml
> +++ b/Documentation/devicetree/bindings/power/power-domain.yaml
> @@ -70,6 +70,16 @@ properties:
> by the given provider should be subdomains of the domain specified
> by this binding.
> + power-supply: true
This is a new property not described in the commit msg.
> + power-supply-needs-irq:
> + type: boolean
> + description:
> + A power-supply can link for example to a regulator controlled via
> + i2c or otherwise needing interrupts enabled to be able to enable and
> + disable.
Not really a property of power domain. How the regulator supply works is
entirely up to regulator. Otherwise such property should appear for
> This property makes various callbacks usually run in the
> + noirq phase, being run when interrupts are available.
Last sentence does not fit - you embed Linux implementation into DT
bindings. noirq phase is Linux specific.
> - "#power-domain-cells"