Re: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM

From: Claudiu.Beznea
Date: Mon Jul 11 2022 - 07:25:33 EST

Hi, Marc,

On 11.07.2022 11:49, Marc Zyngier wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> Claudiu,
> If you send more than a single patch, please add a cover letter.

OK, I'll kept it in mind.

> On Wed, 06 Jul 2022 08:46:29 +0100,
> Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> wrote:
>> Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style
>> recommends (at chapter Conditional Compilation) to avoid using
>> preprocessor conditional in .c files.
>> gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is
>> called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM
>> is not defined. With this gc->chip_types->chip.irq_pm_shutdown is
>> populated all the time as it should be as irq_gc_shutdown() is not
>> conditioned by CONFIG_PM.
> By your very own investigations, aic_suspend() and co are utterly
> useless when !PM. And yet you want to *preserve* them, despite being
> dead code? What purpose does it serve (other than some blind
> compliance to a rule)?

Only compliance with the mentioned rule.

Thank you,
Claudiu Beznea

> M.
> --
> Without deviation from the norm, progress is not possible.