Re: [PATCH] pinctrl: ralink: Check for null return of devm_kcalloc

[Linus Walleij]

On Sun, Jul 10, 2022 at 5:49 PM <williamsukatube@xxxxxxx> wrote:

> From: William Dean <williamsukatube@xxxxxxxxx>
>
> Because of the possible failure of the allocation, data->domains might
> be NULL pointer and will cause the dereference of the NULL pointer
> later.
> Therefore, it might be better to check it and directly return -ENOMEM
> without releasing data manually if fails, because the comment of the
> devm_kmalloc() says "Memory allocated with this function is
> automatically freed on driver detach.".
>
> Fixes: a86854d0c599b ("treewide: devm_kzalloc() -> devm_kcalloc()")
> Reported-by: Hacash Robot <hacashRobot@xxxxxxxxxxx>
> Signed-off-by: William Dean <williamsukatube@xxxxxxxxx>

Patch applied for fixes!

Yours,
Linus Walleij