Re: [PATCH v3 1/2] arm64: topology: move store_cpu_topology() to shared code
From: Greg Kroah-Hartman
Date: Mon Jul 11 2022 - 10:50:50 EST
On Mon, Jul 11, 2022 at 03:35:42PM +0100, Sudeep Holla wrote:
> On Sat, Jul 09, 2022 at 04:23:54PM +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > arm64's method of defining a default cpu topology requires only minimal
> > changes to apply to RISC-V also. The current arm64 implementation exits
> > early in a uniprocessor configuration by reading MPIDR & claiming that
> > uniprocessor can rely on the default values.
> > This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64:
> > topology: Stop using MPIDR for topology information")', because the
> > current code just assigns default values for multiprocessor systems.
> > With the MPIDR references removed, store_cpu_topolgy() can be moved to
> > the common arch_topology code.
> Looks good. FWIW,
> Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> > CC: stable@xxxxxxxxxxxxxxx
> However, while I understand the reason why this is needed in stable trees
> for RISC-V, I am not sure if we want this for stable tree at-least on arm64.
> I leave that part to Greg and Will.
Why would it be good for one arch but bad for another?