Re: [PATCH 5.10-rt] printk: fix suppressed message print when reboot/panic

From: Steven Rostedt
Date: Mon Jul 11 2022 - 12:37:36 EST



I guess the lclaudio@xxxxxxxx is no longer valid. I need to update my
address book :-/

On Mon, 11 Jul 2022 12:31:28 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> Luis,
>
> Care to add this patch into the 5.10-rt stable?
>
> Thanks,
>
> -- Steve
>
> On Mon, 21 Mar 2022 10:36:55 +0106
> John Ogness <john.ogness@xxxxxxxxxxxxx> wrote:
>
> > On 2022-03-21, Schspa Shi <schspa@xxxxxxxxx> wrote:
> > > Update printk_seq for suppressed message.
> > >
> > > Affects 5.9-rt and 5.10-rt
> > >
> > > When message is suppressed, printk_seq should be updated, otherwise
> > > this message will be printed when reboot. This problem was introduced
> > > in commit 3edc0c85d154 ("printk: Rebase on top of new ring buffer").
> > >
> > > Signed-off-by: Schspa Shi <schspa@xxxxxxxxx>
> >
> > Reviewed-by: John Ogness <john.ogness@xxxxxxxxxxxxx>
> >
> > Nice catch. Thanks.
> >
> > 5.15-rt also has this issue, although the fix is slightly different. For
> > 5.15-rt, writing to con->printk_seq (via latched_seq_write()) requires
> > the console locked. Would you like to post a patch for 5.15-rt as well,
> > or would you like me to do it?
> >
> > 5.16 and beyond does not have this issue.
> >
> > John Ogness
>