Re: [PATCH v2] x86/mm/tlb: ignore f->new_tlb_gen when zero

From: Nadav Amit
Date: Mon Jul 11 2022 - 13:39:44 EST


On Jul 10, 2022, at 4:28 PM, Nadav Amit <nadav.amit@xxxxxxxxx> wrote:

> From: Nadav Amit <namit@xxxxxxxxxx>
>
> Commit aa44284960d5 ("x86/mm/tlb: Avoid reading mm_tlb_gen when
> possible") introduced an optimization of skipping the flush if the TLB
> generation that is flushed (as provided in flush_tlb_info) was already
> flushed.

Dave,

Can you please review this patch today?

I feel bad (for a good reason) for breaking swap/migration.

Thanks,
Nadav