Re: [PATCH v1 1/2] dt-bindings: iio: adc: npcm: Add npcm845 compatible string

[Krzysztof Kozlowski]

On 11/07/2022 15:43, Tomer Maimon wrote:
> Add a compatible string for Nuvoton BMC NPCM845 ADC.
> 
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
>  .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml     | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
> index 001cf263b7d5..c9e9c5bf5e5b 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
> @@ -14,7 +14,10 @@ description:
>  
>  properties:
>    compatible:
> -    const: nuvoton,npcm750-adc
> +    oneOf:
> +      - items:

This does not make sense. oneOf with one item. You also create now list
breaking all existing users/ABI.

You probably wanted an enum here.

> +          - const: nuvoton,npcm750-adc
> +          - const: nuvoton,npcm845-adc
>  
>    reg:
>      maxItems: 1


Best regards,
Krzysztof