Re: [PATCH] clk: mediatek: Don't check HW status for mt8192/5's imp_iic_wrap clocks

From: AngeloGioacchino Del Regno
Date: Tue Jul 12 2022 - 06:41:35 EST

Il 11/07/22 22:57, Nícolas F. R. A. Prado ha scritto:
The imp_iic_wrap clocks on mt8192/mt8195 require that the i2c_sel parent
clock be enabled before their hardware status can be checked. Since this
wasn't taken into account, reading from the clk_summary debugfs file
would cause the system to completely freeze.

Assuming that this clock is managed only by the kernel, and not by any
firmware, simply drop the is_enabled() optional callback and instead
rely on the enable count for the imp_iic_wrap clocks.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

For both MT8192 and MT8195:

Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>


drivers/clk/mediatek/clk-gate.c | 6 ++++++
drivers/clk/mediatek/clk-gate.h | 1 +
drivers/clk/mediatek/clk-mt8192-imp_iic_wrap.c | 2 +-
drivers/clk/mediatek/clk-mt8195-imp_iic_wrap.c | 2 +-
4 files changed, 9 insertions(+), 2 deletions(-)