Re: [PATCH v5 1/2] sched/rt: fix bad task migration for rt tasks

[Steven Rostedt]

On Tue, 12 Jul 2022 09:31:24 +0800
Schspa Shi <schspa@xxxxxxxxx> wrote:

> @@ -1998,11 +1998,15 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq)
>  			 * the mean time, task could have
>  			 * migrated already or had its affinity changed.
>  			 * Also make sure that it wasn't scheduled on its rq.
> +			 * It is possible the task was scheduled, set
> +			 * "migrate_disabled" and then got preempted, And we
> +			 * check task migration disable flag here too.

Nit.  "got preempted, so we must check the task migration disable flag here
too".

But other than that.

Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve

>  			 */