Re: [PATCH v3 0/1] add device driver for Nuvoton SIO gpio function
From: Henning Schild
Date: Tue Jul 12 2022 - 11:20:51 EST
Am Tue, 12 Jul 2022 16:42:46 +0200
schrieb Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
> On Tue, Jul 12, 2022 at 4:32 PM Henning Schild
> <henning.schild@xxxxxxxxxxx> wrote:
> > changes since v2:
> > - move from subsys_initcall to module_init
> > - add 2 more patches to show how it can be used later
> > - v2 is based on [PATCH v6 00/12] platform/x86: introduce
> > p2sb_bar() helper
> > changes since v1:
> > - implement get_direction function
> > - style changes requested in review
> JFYI: You have a strange subject. Had you used `git format-patch
> --cover-letter ...`?
Yes, but i changed that subject. Took the old line and turned v2 into
v3. What is strange about it?
> > This adds gpio support for several Super IO chips from Nuvoton. The
> > driver was originally developed by Nuvoton and i am just
> > contributing it on behalf, because other patches i will send later
> > will require access to the gpios. The driver is valid on its own.
> > In fact v2 of this series shows a future user, not to be merged
> > right away but to show what is planned.
> > The driver supports several chips, of which i only managed to test
> > one but did not want to drop the others.
> > I hope the original authors will help with the testing and
> > addressing review feedback. The changes i did so far mainly are
> > inspired by similar drivers and some just concern coding style. If
> > more has to be done and the original authors do not jump in, we
> > might start off with just that one chip i can test and add the
> > others later on.