Re: [RFC PATCH 3/3] arm64: dts: bcmbca: update bcm4808 board dts file

From: William Zhang
Date: Tue Jul 12 2022 - 13:48:11 EST



On 7/12/22 08:50, Krzysztof Kozlowski wrote:
On 12/07/2022 17:36, Florian Fainelli wrote:
On 7/12/22 00:47, Krzysztof Kozlowski wrote:
On 12/07/2022 04:11, William Zhang wrote:
Update compatible string based on the new bcmbca binding rule
for BCM4908 famliy based boards

Typo - family

Please explain why breaking the ABI (and users of these DTS_ is acceptable.

This will be largely targeted towards Rafal who supports these kinds of
devices with an upstream kernel. My understanding is that this is OK
because we will always ship a DTB matching the Linux kernel, and I
believe this is true for both the way that William and his group support
these devices, as well as how OpenWrt, buildroot or other build systems
envision to support these devices.
Yes that is correct for bca group.


Rafal, does that sound about right?

I am fine, just maybe mention it in the commit because it literally
breaks the DTSes.

I assume you considered all possible uses outside of Linux like U-Boot,
BSD etc?

Best regards,
Krzysztof

The reason for this patch is to keep the bcmbca board dts in the same format and keep everything in the same yaml file. Understand 4908 was already upstream but luckily there is no driver in linux and u-boot that uses these 4908 compatible strings. They are only used in the board dts as far as I can see. So it does not really break anything in the end, unless someone use them in any driver but never upstream their code...

Rafal, please let us know if this is okay with you or any concern/possible break of existing system.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature