Re: [PATCH v4 2/2] pinctrl: ocelot: Fix pincfg

From: Colin Foster
Date: Tue Jul 12 2022 - 21:35:50 EST

On Tue, Jul 12, 2022 at 09:50:43PM +0200, Horatiu Vultur wrote:
> The blamed commit changed to use regmaps instead of __iomem. But it
> didn't update the register offsets to be at word offset, so it uses byte
> offset.
> Another issue with the same commit is that it has a limit of 32 registers
> which is incorrect. The sparx5 has 64 while lan966x has 77.
> Fixes: 076d9e71bcf8 ("pinctrl: ocelot: convert pinctrl to regmap")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>

Acked-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx>