Re: [PATCH 4/6] gpiolib: cdev: simplify line event identification

From: Andy Shevchenko
Date: Wed Jul 13 2022 - 05:59:53 EST


On Wed, Jul 13, 2022 at 3:39 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> Reorganise line event identification code to reduce code duplication,
> and replace if-else initializers with the ternary equivalent to
> improve readability.

...

> + le.id = level ? GPIO_V2_LINE_EVENT_RISING_EDGE :
> + GPIO_V2_LINE_EVENT_FALLING_EDGE;

It seems several times you are doing the same, perhaps a helper?

--
With Best Regards,
Andy Shevchenko