Re: [PATCH 3/7] pwm: dwc: add of/platform support

From: Ben Dooks
Date: Wed Jul 13 2022 - 08:06:17 EST


On 12/07/2022 15:26, Rob Herring wrote:
On Tue, 12 Jul 2022 11:01:09 +0100, Ben Dooks wrote:
The dwc pwm controller can be used in non-PCI systems, so allow
either platform or OF based probing.

Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxx>
---
.../devicetree/bindings/pwm/pwm-synposys.yaml | 40 ++++++++++++++
drivers/pwm/Kconfig | 5 +-
drivers/pwm/pwm-dwc.c | 53 +++++++++++++++++++
3 files changed, 96 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pwm/pwm-synposys.yaml


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

Is the following equivalent:

make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/pwm/snps,pwm.yaml


yamllint warnings/errors:
./Documentation/devicetree/bindings/pwm/pwm-synposys.yaml:11:4: [warning] wrong indentation: expected 2 but found 3 (indentation)
./Documentation/devicetree/bindings/pwm/pwm-synposys.yaml:31:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

Whoops, turns out I hadn't installed yamllint.

pip3 install dtschema --upgrade

Please check and re-submit.