Re: [PATCH] net/mlx5e: Removed useless code in function

From: Saeed Mahameed
Date: Wed Jul 13 2022 - 18:26:47 EST


On 11 Jul 12:33, Rustam Subkhankulov wrote:
Comparison of eth_ft->ft with NULL is useless, because
get_flow_table() returns either pointer 'eth_ft'
such that eth_ft->ft != NULL, or an erroneous value that is
handled on return, causing mlx5e_ethtool_flow_replace()
to terminate before checking whether eth_ft->ft equals NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Rustam Subkhankulov <subkhankulov@xxxxxxxxx>
Fixes: 6dc6071cfcde ("net/mlx5e: Add ethtool flow steering support")

Applied to net-next-mlx5 and removed the fixes tag. Since there is no bug
here.

Thanks,
Saeed.