Re: [PATCH -next] habanalabs: Simplify bool conversion

[Oded Gabbay]

On Thu, Jul 14, 2022 at 4:29 AM Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:
>
> Fix the following coccicheck warning:
> ./drivers/misc/habanalabs/gaudi2/gaudi2.c:9727:48-53: WARNING:
> conversion to bool not needed here
>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/misc/habanalabs/gaudi2/gaudi2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi2/gaudi2.c b/drivers/misc/habanalabs/gaudi2/gaudi2.c
> index 98336a1a84b0..344b4dedef41 100644
> --- a/drivers/misc/habanalabs/gaudi2/gaudi2.c
> +++ b/drivers/misc/habanalabs/gaudi2/gaudi2.c
> @@ -9724,7 +9724,7 @@ static int gaudi2_get_mmu_base(struct hl_device *hdev, u64 mmu_id, u32 *mmu_base
>
>  static void gaudi2_ack_mmu_error(struct hl_device *hdev, u64 mmu_id)
>  {
> -       bool is_pmmu = (mmu_id == HW_CAP_PMMU ? true : false);
> +       bool is_pmmu = (mmu_id == HW_CAP_PMMU);
>         struct gaudi2_device *gaudi2 = hdev->asic_specific;
>         u32 mmu_base;
>
> --
> 2.20.1.7.g153144c
>
This patch is:
Reviewed-by: Oded Gabbay <ogabbay@xxxxxxxxxx>

Applied to -next.
Thanks,
Oded