Re: [PATCH] x86: Allow for exclusions in checking RETHUNK

From: Peter Zijlstra
Date: Thu Jul 14 2022 - 03:18:48 EST


On Wed, Jul 13, 2022 at 04:55:56PM -0700, Josh Poimboeuf wrote:
> Here's the ANNOTATE_UNSAFE_RET idea.

Right, I suppose that strictly speaking the compiler can do whatever and
there's no actual guarantee the annotation hits the RET instruction, in
practise it should work, esp. since noinstr.

> Most of the diff is moving the
> annotation macros to objtool.h (where they belong anyway).

Yeah, moving those is a good idea.