Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN

From: Michael Walle
Date: Thu Jul 14 2022 - 03:42:03 EST


Am 2022-07-13 23:01, schrieb Jae Hyun Yoo:
On 7/13/2022 7:32 AM, Michael Walle wrote:
Am 2022-07-13 16:26, schrieb Jae Hyun Yoo:
+    { "w25q512nwq", INFO(0xef6020, 0, 64 * 1024, 1024)

Please use INFO(0xef6020, 0, 0, 0) and test wether it will still
work correctly. We will then be able to convert it to SNOR_ID3()

Tested it but it doesn't work with INFO(0xef6020, 0, 0, 0). I'll keep
it as is.

Can you please look into this? I'd expect this to work if the SFDP
tables are correct because all this should come from the tables.
You can look at /sys/kernel/debug/spi-nor/spi0.0/params and see
what is changing there.

I tested it again but result is still the same. I can check the parsed
info like below if I use INFO(0xef6020, 0, 64 * 1024, 1024) but I can't
even check the debugfs info if I use INFO(0xef6020, 0, 0, 0) since it
doesn't boot at all. I think, this patch should go as is and the size
parsing issue could be fixed using a separate fix.

What does "doesn't boot at all" mean? Are there any kernel startup

Just to be sure, you have PARSE_SFDP set, right?

The entry should be (skipping OTP to make sure that isn't
the problem here):
{ "w25q512nwq", INFO(0xef6020, 0, 0, 0) PARSE_SFDP }