Re: [PATCH v2 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix
From: Krzysztof Kozlowski
Date: Thu Jul 14 2022 - 05:32:05 EST
On 14/07/2022 10:12, Johan Hovold wrote:
> On Thu, Jul 07, 2022 at 03:46:55PM +0200, Johan Hovold wrote:
>> When adding support for SC8280XP to the QMP PHY driver I noticed that
>> the PHY provider child node was not described by the current DT schema.
>> The SC8280XP PHYs also need a second fixed-divider PIPE clock
>> ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to
>> the clock name just to match the current "pipe0" name so I decided to
>> deprecate the unnecessary suffix in the current binding instead.
>> To be able to add the missing child-node schema and handle device
>> specifics like additional PIPE clocks, it quickly became obvious that
>> the binding needs to be split up.
>> This series clean up and fixes some issue with the current schema before
>> splitting it up in separate schemas for PCIe, UFS and USB and adding
>> missing parts like the child PHY provider nodes.
>> The MSM8996 PCIe PHY gets its own schema as this is the only non-combo
>> PHY that actually provides more than one PHY per IP block. Note that the
>> "lane" suffix is still unnecessary and misleading.
>> The final patches add support for the updated binding to the (recently
>> split up) PHY drivers. Included is also a related combo PHY cleanup.
>> Changes in v2
>> - squash split + cleanup + example patches (Krzysztof)
>> - deprecate clock-names instead of dropping suffix (Krzysztof)
>> - deprecate reset-names instead of dropping suffix (Krzysztof)
>> - flatten child reg if/then schemas (Krzysztof)
>> - add back optional vddp-ref-clk to all bindings even though it likely
>> only applies to MSM8996/98 UFS (Krzysztof)
>> - add missing sc7180 schema to USB binding
>> - misc clean ups
>> - shorten or drop descriptions
>> - drop quotes around $id and $schema (Krzysztof)
>> - use maxItems with clock-output-names
>> - combine two USB clock+reset schemas
>> - add Reviewed-by/Acked-by tags
> Any further comments to this series?
> Vinod, I noticed there was a conflict when rebasing on linux-next due to
> commit 85d43a69db2d ("dt-bindings: phy: qcom,qmp: add IPQ8074 PCIe Gen3
> PHY binding").
I got few comments. Apologies for a slow review, I am a bit overloaded.