RE: [PATCH] regulator: da9063: disable unused voltage monitors

From: DLG Adam Thomson
Date: Thu Jul 14 2022 - 05:36:09 EST

On 13 July 2022 13:50, Benjamin Bara wrote:

> From: Benjamin Bara <benjamin.bara@xxxxxxxxxxx>
> This enables the kernel to disable the voltage monitor of unused regs.
> Some boards might use the PWR_OK functionality, which asserts GP_FB2
> if each measured voltage is in-range.
> However, if a regulator (which is enabled and monitored) is disabled,
> also its voltage monitor must be disabled to keep a valid PWR_OK state.

This proposal seemingly doesn't work. If you disable monitoring of a regulator,
and no other regulators are being monitored at that point, then GP_FB2 will no
longer be asserted and you have the same issue. What's more this patch impacts
all users and there's no means to re-enable monitoring. Certainly in the current
state this isn't a valid change.

What exactly is the problem you're attempting to resolve through this patch?