Re: [PATCH v2 28/30] phy: qcom-qmp-pcie-msm8996: drop pipe clock lane suffix

[Johan Hovold]

On Thu, Jul 14, 2022 at 11:30:36AM +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 15:47, Johan Hovold wrote:
> > The pipe clock is defined in the "lane" node so there's no need to keep
> > adding a redundant lane-number suffix to the clock name.
> > 
> > Update driver to support the new binding where the pipe clock name has
> > been deprecated by instead requesting the clock by index.
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > ---
> >  drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
> > index 812d14afb5ec..af2f14a53b38 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
> > @@ -872,7 +872,6 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np,
> >  	struct qcom_qmp *qmp = dev_get_drvdata(dev);
> >  	struct phy *generic_phy;
> >  	struct qmp_phy *qphy;
> > -	char prop_name[MAX_PROP_NAME];
> 
> Wait, it looks like your patchset is not bisectable. Be sure each commit
> compiles cleanly.

Ah, crap. I apparently fixed up the wrong commit when I noticed the
unused prop_name variable.

Will fix in v3.

Johan