Re: [PATCH v2] AMD_SFH: Add a DMI quirk entry for Chromebooks

From: Mario Limonciello
Date: Thu Jul 14 2022 - 07:39:13 EST


On 7/14/22 00:37, Akihiko Odaki wrote:
Google Chromebooks use Chrome OS Embedded Controller Sensor Hub instead
of Sensor Hub Fusion and leaves MP2 uninitialized, which disables all
functionalities, even including the registers necessary for feature
detections.

The behavior was observed with Lenovo ThinkPad C13 Yoga.

Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxx>
Suggested-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index dadc491bbf6b..b91e1c95e543 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -197,6 +197,18 @@ static const struct dmi_system_id dmi_sensor_mask_overrides[] = {
},
.driver_data = (void *)(ACEL_EN | MAGNO_EN),
},
+ {
+ /*
+ * Google Chromebooks use Chrome OS Embedded Controller Sensor
+ * Hub instead of Sensor Hub Fusion and leaves MP2
+ * uninitialized, which disables all functionalities, even
+ * including the registers necessary for feature detections.
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Google"),
+ },
+ .driver_data = (void *)0,
+ },
{ }
};

Did you miss my other comment on v1 on discovery sensor probing or is it not a problem?