Re: [PATCH] PCI: qcom: Add support for modular builds

From: Dmitry Baryshkov
Date: Thu Jul 14 2022 - 09:05:50 EST


Hi Stanimir,

On 14/07/2022 15:19, Stanimir Varbanov wrote:
Hi Johan,

Please take a look why we made it built-in first [1].

If arguments there are still valid I don't see why to make it a module
again.

[1] https://lkml.org/lkml/2016/8/24/694

It looks like there is a move to make all non-essential drivers buildable as modules. For example, the Kirin, dra7xx, Meson PCI controllers are now buildable as modules. So I think we can follow that and allow building the pcie-qcom as a module.


On 5/19/22 12:46, Johan Hovold wrote:
Allow the Qualcomm PCIe controller driver to be built as a module, which
is useful for multi-platform kernels as well as during development.

Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
---
drivers/pci/controller/dwc/Kconfig | 2 +-
drivers/pci/controller/dwc/pcie-qcom.c | 36 +++++++++++++++++++++++---
2 files changed, 34 insertions(+), 4 deletions(-)





--
With best wishes
Dmitry