Re: Question: regmap_field_write() - why using update?

From: Mark Brown
Date: Thu Jul 14 2022 - 14:27:41 EST


On Thu, Jul 14, 2022 at 05:15:34PM +0200, Krzysztof Kozlowski wrote:
> On 14/07/2022 17:13, Krzysztof Kozlowski wrote:

> > Indeed, I forgot about bits in a field... So it has to be like this or I
> > need to use regmap_write(). I find the regmap field API very useful for
> > devices with different register layouts, but the actual "fields" part is
> > not really needed in my case.

> ... and few registers (like "clear" registers) actually do not allow to
> read.

The write only registers are a good point - we could handle them through
special casing, that'd avoid any overhead from reading or issues if a
physical read happens to return something unfortunate for some reason.
Now I think about it there's also the fun case of registers which don't
have symmetric read and write, though at some point regmap_field does
stop being useful and those might well be pushing it.

Attachment: signature.asc
Description: PGP signature