Re: [PATCH bpf-next v6 00/23] Introduce eBPF support for HID devices

From: Alexei Starovoitov
Date: Thu Jul 14 2022 - 17:39:29 EST


On Tue, Jul 12, 2022 at 04:58:27PM +0200, Benjamin Tissoires wrote:
> Hi,
>
> and after a little bit of time, here comes the v6 of the HID-BPF series.
>
> Again, for a full explanation of HID-BPF, please refer to the last patch
> in this series (23/23).
>
> This version sees some improvements compared to v5 on top of the
> usual addressing of the previous comments:
> - now I think every eBPF core change has a matching selftest added
> - the kfuncs declared in syscall can now actually access the memory of
> the context
> - the code to retrieve the BTF ID of the various HID hooks is much
> simpler (just a plain use of the BTF_ID() API instead of
> loading/unloading of a tracing program)
> - I also added my HID Surface Dial example that I use locally to provide
> a fuller example to users

Looking great.
Before another respin to address bits in patch 12 let's land the first ~8 patches,
since they're generic useful improvements.

Kumar, could you please help review the verifier bits?