Re: [PATCH v2 00/10] lib: cleanup bitmap-related headers

From: Yury Norov
Date: Thu Jul 14 2022 - 18:15:28 EST


On Tue, Jul 12, 2022 at 09:28:21AM -0700, Yury Norov wrote:
> On Wed, Jul 6, 2022 at 10:42 AM Yury Norov <yury.norov@xxxxxxxxx> wrote:
> >
> > This series unifies declarations of bitmap-related functions and aligns
> > return types with values that actually returned. Also, it moves one-liner
> > wrappers around cpumask functions into headers, so that compiler has a
> > chance to optimize better.
> >
> > With this series, GCC 11.2 for ARM64 with kernel v5.19-rc4:
> > add/remove: 15/7 grow/shrink: 461/164 up/down: 14844/-4580 (10264)
> >
> > This +10K didn't surprise me because modern compilers are more aggressive
> > in inlining, loop unrolling, and other techniques that increase size of
> > the image.
> >
> > v1: https://lore.kernel.org/linux-mm/YsAzU3g2QpgmIGre@xxxxxxxxxxxxxxxxxx/T/
> > v2: - Align whitespaces in headers;
> > - Make bitmap_weight() unsigned long consistently;
> > - Pick 2 patches from Ingo's sched/headers series [1] that split
> > linux/gfp.h, and drop my similar patch for it.
>
> Ping?

OK, I realize that it's not the very entertaining thing to review a
headers cleanup.

Adding this into -next because there's no negative feedback (he-he).