Re: Linux 5.19-rc6
From: Geert Uytterhoeven
Date: Fri Jul 15 2022 - 03:26:39 EST
On Thu, Jul 14, 2022 at 7:24 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On 7/14/22 09:48, Linus Torvalds wrote:
> > And some look positively strange. Like that
> > drivers/mfd/asic3.c: error: unused variable 'asic'
> > [-Werror=unused-variable]: => 941:23
> > which is clearly used three lines later by
> > iounmap(asic->tmio_cnf);
> > and I can't find any case of 'iounmap()' having been defined to an
> > empty macro or anything like that to explain it. The error in
> > drivers/tty/serial/sh-sci.c looks to be exactly the same issue, just
> > with ioremap() instead of iounmap().
> > It would be good to have some way to find which build/architecture it
> > is, because right now it just looks bogus.
> > Do you perhaps use some broken compiler that complains when the empty
> > inline functions don't use their arguments? Because that's what those
> > ioremap/iounmap() ones look like to me, but there might be some
> > magical architecture / config that has issues that aren't obvious.
> > IOW, I'd love to get those fixed, but I would also want a little bit more info.
> Geert gave the necessary hint - it looks like sh-nommu used defines
> for iomap() and iounmap(), which made the variable unused. According
> to Geert that was fixed a couple of days ago.
Yes, post-rc6 should be fine, as the fix went in... for the third time.
Combine people that keep on switching back to macros without reading
a file's history with unresponsive maintainers...
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds