Re: [net-next PATCH] net: dsa: qca8k: move driver to qca dir

From: Christian Marangi
Date: Fri Jul 15 2022 - 04:24:00 EST

On Thu, Jul 14, 2022 at 10:03:54PM -0700, Jakub Kicinski wrote:
> On Wed, 13 Jul 2022 22:53:50 +0200 Christian Marangi wrote:
> > This is a start for the required changes for code
> > split. Greg wasn't so negative about this kind of change
> > so I think we can finally make the move.
> >
> > Still waiting some comments about the code split.
> > (Can I split qca8k to common function that will be
> > used by ipq4019? (and later propose the actual
> > ipq4019 driver?))
> Does the split mean that this code will move again?
> If so perhaps better to put this patch in the series
> that does the split? We're ~2 weeks away from the merge
> window so we don't want to end up moving the same code
> twice in two consecutive releases.

What to you mean with "will move again"?

The code will be split to qca8k-common.c and qca8k-8xxx.c
And later qca8k-ipq4019.c will be proposed.

So the files will all stay in qca/ dir.

Or should I just propose the move and the code split in one series?

Tell me what do you prefer.