Re: [PATCH v3] printk: do not wait for consoles when suspended

From: Petr Mladek
Date: Fri Jul 15 2022 - 05:16:16 EST


On Fri 2022-07-15 08:16:42, John Ogness wrote:
> The console_stop() and console_start() functions call pr_flush().
> When suspending, these functions are called by the serial subsystem
> while the serial port is suspended. In this scenario, if there are
> any pending messages, a call to pr_flush() will always result in a
> timeout because the serial port cannot make forward progress. This
> causes longer suspend and resume times.
>
> Add a check in pr_flush() so that it will immediately timeout if
> the consoles are suspended.
>
> Fixes: 3b604ca81202 ("printk: add pr_flush()")
> Reported-by: Todd Brandt <todd.e.brandt@xxxxxxxxxxxxxxx>
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>
> Tested-by: Todd Brandt <todd.e.brandt@xxxxxxxxxxxxxxx>

The patch is committed in printk/linux.git, branch rework/kthreads.

I think about creating pull request for 5.19 later today or tomorrow
so that it is in the last rc.

Best Regards,
Petr