Re: [PATCH v1 1/6] dma-buf: Add _unlocked postfix to function names
From: Dmitry Osipenko
Date: Fri Jul 15 2022 - 05:31:49 EST
On 7/15/22 10:19, Christian König wrote:
>> -struct sg_table *dma_buf_map_attachment(struct dma_buf_attachment
>> - enum dma_data_direction direction)
>> +struct sg_table *
>> +dma_buf_map_attachment_unlocked(struct dma_buf_attachment *attach,
>> + enum dma_data_direction direction)
> The locking state of mapping and unmapping operations depend on if the
> attachment is dynamic or not.
> So this here is not a good idea at all since it suggests that the
> function is always called without holding the lock.
I had the same thought while was working on this patch and initially was
thinking about adding an "unlocked" alias to dma_buf_map_attachment().
In the end I decided that it will create even more confusion and it's
simpler just to rename this func here since there are only two drivers
using the dynamic mapping.
Do you have suggestions how to improve it?