Re: [PATCH V2 net-next] net: marvell: prestera: add phylink support

[Oleksandr Mazur]

Hello Russel,

First of all - sorry for the inconveniences with the rush of new versioned-patches, my bad; won't happen again

As for the comments:

> I didn't specifically ask about the ifdefs - I asked the general
> question about "why make phylink conditional for this driver".
> Yes, v1 had ifdefs. v2 does not, but phylink is _still_ conditional.
> You are introduing lots of this pattern of code:

Sorry i think i misunderstood your question of the <conditional> use of phylink driver.
The reason is the following: the current state of things with ports is that PHY ports are controlled by FW,
and we're using phylink only for SFP ports. We don't have an PHY regs read/write invocation interfaces from driver right now,
and thus PHY ports control is limited to controlling them from FW side only, for now.

> 3. As for AN restart, no, it's not yet supported by our FW as of now.
> Maybe put a comment in the code to that effect?
That would make sense, i will add a comment in the next patch version.