Re: [PATCH 3/5] staging: r8188eu: remove unused parameter from update_TSF()

From: Dan Carpenter
Date: Fri Jul 15 2022 - 05:49:38 EST

Next message: Frans Klaver: "[PATCH] usb: serial: qcserial: add EM9191 support"
Previous message: Pavan Kondeti: "Re: [PATCH] usb: dwc3: qcom: Defer dwc3-qcom probe if dwc3 isn't probed properly"
In reply to: Michael Straube: "[PATCH 3/5] staging: r8188eu: remove unused parameter from update_TSF()"
Next in thread: Michael Straube: "[PATCH 4/5] staging: r8188eu: make update_TSF() and correct_TSF() static"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Jul 15, 2022 at 08:29:06AM +0200, Michael Straube wrote:
> The parameter 'len' of update_TSF() is unused. Remove it.
>

I really do think this driver should do a lot of more checking on len.

It's not totally clear to me if this len can even be trusted though...

regards,
dan carpenter

Next message: Frans Klaver: "[PATCH] usb: serial: qcserial: add EM9191 support"
Previous message: Pavan Kondeti: "Re: [PATCH] usb: dwc3: qcom: Defer dwc3-qcom probe if dwc3 isn't probed properly"
In reply to: Michael Straube: "[PATCH 3/5] staging: r8188eu: remove unused parameter from update_TSF()"
Next in thread: Michael Straube: "[PATCH 4/5] staging: r8188eu: make update_TSF() and correct_TSF() static"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]