Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context
From: Andrey Grodzovsky
Date: Fri Jul 15 2022 - 11:18:26 EST
On 2022-07-14 17:16, Alex Deucher wrote:
On Thu, Jul 14, 2022 at 1:58 PM Andrey Grodzovsky
<andrey.grodzovsky@xxxxxxx> wrote:
On 2022-07-14 12:22, Alex Deucher wrote:
On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky
<andrey.grodzovsky@xxxxxxx> wrote:
On 2022-07-14 05:57, Dmitry Osipenko wrote:
On 7/12/22 11:56, Dmitry Osipenko wrote:
On 7/6/22 18:46, Alex Deucher wrote:
On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky
<andrey.grodzovsky@xxxxxxx> wrote:
On 2022-07-06 03:07, Dmitry Osipenko wrote:
Hello Andrey,
On 5/17/22 17:48, Dmitry Osipenko wrote:
On 5/17/22 17:13, Andrey Grodzovsky wrote:
Done.
Andrey
Awesome, thank you!
Given that this drm-scheduler issue needs to be fixed in the 5.19-RC and
earlier, shouldn't it be in the drm-fixes and not in drm-next?
I pushed it into drm-misc from where it got into drm-next. I don't have
permission for drm-fixes.
The -fixes branch of drm-misc.
Now I don't see the scheduler bugfix neither in the -fixes branch nor in
the -next and today Dave sent out 5.19-rc7 pull request without the
scheduler fix. Could anyone please check what is going on with the DRM
patches? Thanks!
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffreedesktop%2Fdrm-misc%2Fcommits%2Fdrm-misc-fixes&data=05%7C01%7Candrey.grodzovsky%40amd.com%7C9585d3814d9b4e51bfcb08da65de368d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637934302314091129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QjSspRJyOZpFOoaA988nH2V7Gq54gSUl6mm87B1sYhE%3D&reserved=0
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fdrm%2Fdrm-misc%2Flog%2F%3Fh%3Ddrm-misc-fixes&data=05%7C01%7Candrey.grodzovsky%40amd.com%7C9585d3814d9b4e51bfcb08da65de368d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637934302314091129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=8ysjuD7Ufsyu5c%2BfRdpT9nkWHjotsd1cjCfy4yRw2uw%3D&reserved=0
The patch is in the drm-misc-next-fixes, so it wasn't moved to the
drm-misc-fixes.
Andrey, don't you have access to drm-misc-fixes? Or you meant
drm-fixes=drm-misc-fixes?
I have only accesses to drm-misc-next to which I pushed this patch.
anyone with drm-misc rights can commit to any of the branches in the
drm-misc tree. You just need to check out and push the appropriate
branch. then push the changes. E.g.,
dim push-branch drm-misc-next
vs
dim push-branch drm-misc-next-fixes
etc.
Alex
I see, but what is the reason then that Dave sent out 5.19-rc7 pull
request without the
scheduler fix if the patch was merged into drm-misc-next long ago ? All
the changes from
there are usually picked up for pull requests, no ?
drm-misc-next is for new stuff for the next kernel (e.g., 5.20).
drm-misc-fixes is for fixes for the current kernel cycle (e.g., 5.19).
See:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fdrm-misc.html&data=05%7C01%7Candrey.grodzovsky%40amd.com%7C9585d3814d9b4e51bfcb08da65de368d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637934302314091129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=8IW3uNvSEogYjj%2BNKh1b9jkT5CaJ5osZ9GgEcI8zyqo%3D&reserved=0
Alex
Got it, Dmitry, I pushed this time to drm-misc-fixes so i hope this time
it will be picked up for next rc release.
Andrey
Andrey
Andrey