Re: [PATCH v1 0/4] PCI: brcmstb: Re-submit reverted patchset

From: Bjorn Helgaas
Date: Fri Jul 15 2022 - 14:27:27 EST


On Fri, Jul 01, 2022 at 12:27:21PM -0400, Jim Quinlan wrote:
> A submission [1] was made to enable a PCIe root port to turn on regulators
> for downstream devices. It was accepted. Months later, a regression was
> discovered on an RPi CM4 [2]. The patchset was reverted [3] as the fix
> came too late in the release cycle. The regression in question is
> triggered only when the PCIe RC DT node has no root port subnode, which is
> a perfectly reasonsable configuration.
> ...

> Jim Quinlan (4):
> PCI: brcmstb: Split brcm_pcie_setup() into two funcs
> PCI: brcmstb: Add mechanism to turn on subdev regulators
> PCI: brcmstb: oAdd control of subdevice voltage regulators
> PCI: brcmstb: Do not turn off WOL regulators on suspend
>
> drivers/pci/controller/pcie-brcmstb.c | 257 +++++++++++++++++++++++---
> 1 file changed, 227 insertions(+), 30 deletions(-)

I'm assuming there's a v2 coming soonish? We should see -rc7 this
weekend and likely a final v5.19 release on July 24, so v5.20 material
should be tidied up by then.

Bjorn